Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid triggering rollback checks if no ComponentSyncMode::Full components have been updated #817

Open
cBournhonesque opened this issue Jan 13, 2025 · 0 comments

Comments

@cBournhonesque
Copy link
Owner

Scenario:

  • spawn entity E with a C1 (ComponentSyncMode::Full) and C2 (ComponentSyncMode::Simple)
  • send an update for C2
  • rollback_check runs for E because the confirmed_tick has been updated.

We should only update the confirmed.tick if the update contained a ComponentSyncMode::Full update. (confirmed.tick is only used for prediction/interpolation)

Example: the player entity constantly runs rollback_checks in the spaceships example because the Player component keeps getting updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant