Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The lib names from msvc_sdk are being mismatched #1635

Closed
ygorpontelo opened this issue Nov 21, 2024 · 10 comments
Closed

The lib names from msvc_sdk are being mismatched #1635

ygorpontelo opened this issue Nov 21, 2024 · 10 comments
Assignees
Labels
Accepted Accepted Request Enhancement Request New feature or request Implemented Needs Verification Check if this issue is resolved
Milestone

Comments

@ygorpontelo
Copy link
Contributor

ygorpontelo commented Nov 21, 2024

As mentioned in this issue , the names from the libs downloaded from the python script are being matched with case sensitive, which causes errors when trying to link against them.

For example:

lld-link: error: could not open 'gdi32.lib': No such file or directory
lld-link: error: could not open 'winmm.lib': No such file or directory
lld-link: error: could not open 'dbghelp.lib': No such file or directory
lld-link: error: could not open 'kernel32.lib': No such file or directory
lld-link: error: could not open 'user32.lib': No such file or directory
lld-link: error: could not open 'Shlwapi.lib': No such file or directory
lld-link: error: could not open 'Ws2_32.lib': No such file or directory
lld-link: error: could not open 'MSVCRT.lib': No such file or directory
lld-link: error: could not open 'OLDNAMES.lib': No such file or directory
lld-link: error: could not open 'uuid.lib': No such file or directory
Failed to create an executable: (null)

Discussed solution would be to adjust the script to rename the libs to the format expected by the compiler.

@lerno
Copy link
Collaborator

lerno commented Nov 21, 2024

I have updated the python script and the built in links. See if it works better.

@lerno lerno self-assigned this Nov 21, 2024
@lerno lerno added Enhancement Request New feature or request Implemented Needs Verification Check if this issue is resolved Accepted Accepted Request labels Nov 21, 2024
@lerno lerno added this to the 0.6.5 milestone Nov 21, 2024
@ygorpontelo
Copy link
Contributor Author

Most of the errors are gone, just had two now:

lld-link: error: could not open 'MSVCRT.lib': No such file or directory
lld-link: error: could not open 'OLDNAMES.lib': No such file or directory
Failed to create an executable: (null)

@lerno
Copy link
Collaborator

lerno commented Nov 23, 2024

Where are those from?

@lerno
Copy link
Collaborator

lerno commented Nov 23, 2024

I can't find anything like that in my sources.

@ygorpontelo
Copy link
Contributor Author

I can find them in the generated msvc_sdk, but they are lowercase. I'm also trying to link with raylib, so this could be a specific dependency there. I'm on Linux host.

@lerno
Copy link
Collaborator

lerno commented Nov 23, 2024

The clang rt with asan seems to use those names.

@ygorpontelo
Copy link
Contributor Author

ygorpontelo commented Nov 23, 2024

That explains it. I don't think we can predict what naming each lib will use, but we could put a note in the docs warning people about it, so they can rename it as needed, or rather create links for it.

@ygorpontelo
Copy link
Contributor Author

This looks good to me, we can close it in my opinion.

@lerno
Copy link
Collaborator

lerno commented Nov 23, 2024

I've updated the script so that we get both a copy MSVCRT and OLDNAMES.lib as well as the lower case versions. Try it out!

@ygorpontelo
Copy link
Contributor Author

Works out of the box now. Much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted Request Enhancement Request New feature or request Implemented Needs Verification Check if this issue is resolved
Projects
None yet
Development

No branches or pull requests

2 participants