Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set resource-creator-email tag to GitHub-Actions #655

Closed
GaryGSC opened this issue Oct 11, 2022 · 2 comments · Fixed by #661
Closed

Set resource-creator-email tag to GitHub-Actions #655

GaryGSC opened this issue Oct 11, 2022 · 2 comments · Fixed by #661
Labels
enhancement New feature or request terraform Pull requests that update Terraform code

Comments

@GaryGSC
Copy link
Member

GaryGSC commented Oct 11, 2022

We have a lot of noise in our Terraform plans because we evidently have some background process adding this tag to our resources. Let's add that tag ourselves to cut down on the noise.

@GaryGSC GaryGSC added enhancement New feature or request terraform Pull requests that update Terraform code labels Oct 11, 2022
@GaryGSC
Copy link
Member Author

GaryGSC commented Oct 13, 2022

Clearly this introduces an opinion (#214), but this is pretty non-intrusive and tags are free.

@GaryGSC
Copy link
Member Author

GaryGSC commented Oct 14, 2022

Example:

  # module.app.module.my_fargate_api.aws_ecs_cluster.new_cluster[0] has changed
  ~ resource "aws_ecs_cluster" "new_cluster" {
        id                 = "arn:aws:ecs:us-west-2:***:cluster/hw-fargate-api-dev"
        name               = "hw-fargate-api-dev"
      ~ tags               = {
          + "resource-creator-email" = "GitHub-Actions"
        }
      ~ tags_all           = {
          + "resource-creator-email" = "GitHub-Actions"
            # (3 unchanged elements hidden)
        }
        # (2 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request terraform Pull requests that update Terraform code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant