need help, javacv 1.5.9 memory leak

[shaoneng111]

environment : centos 6.8
jdk: java8
problem: memory is growing slowly

mycode:

public static VideoComputeInfo computeVideoQuality(String videoContentId, InputStream videoInputStream) {
if (videoInputStream == null) {
return null;
}
long startTime = System.currentTimeMillis();
// 直接指定maximumSize
FFmpegFrameGrabber grabber = new FFmpegFrameGrabber(videoInputStream, 1000000);
grabber.setCloseInputStream(true);
try {
// 截取jpeg文件
grabber.start();
// 视频帧率
Integer frameRate = (int) grabber.getVideoFrameRate();
// 视频时长
int timeLen = (int) Math.ceil((double) grabber.getLengthInTime() / 1000000);
int frameWidth = grabber.getImageWidth();
int frameHeight = grabber.getImageHeight();
// 视频文件大小
int videoSize = videoInputStream.available();
long endTime = System.currentTimeMillis();
VideoComputeInfo videoComputeInfo = VideoComputeInfo.builder()
.frameRate(frameRate)
.height(frameHeight)
.width(frameWidth)
.timeLen(timeLen)
.videoSize(videoSize)
.build();
log.info("FfmpegUtil computeVideoQuality耗时：{}, videoContentId: {}, videoComputeInfo: {}"
, endTime - startTime, videoContentId, videoComputeInfo);
return videoComputeInfo;
} catch (Exception e) {
log.error("FfmpegUtil computeVideoQuality异常，异常信息：", e);
} finally {
try {
grabber.close();
} catch (Exception e) {
log.error("FfmpegUtil grabber.close()异常，异常信息：", e);
}
}
return null;
} 

i don't know what's wrong with it

[saudet]

If the problem doesn't occur without VideoComputeInfo, it's a problem with your VideoComputeInfo, not JavaCV.

[shaoneng111]

thank you for your reply! but VideoComputeInfo is a simple java object , use java heap. i analysis the java heap memory, its looks like normal, so the leak occurs not in java heap?

[saudet]

If you can reproduce the issue without VideoComputeInfo, please provide such sample code.

[shaoneng111]

thank you for your reply! but VideoComputeInfo is a simple java object , use java heap. i analysis the java heap memory, its looks like normal, so the leak occurs not in java heap?

and VideoComputeInfo should occupy very little memory, but actually it will eat 1G memory one day

[shaoneng111]

i also want to know , Is the way I'm using javacv correct?

[saudet]

Looks alright, but the problem might also be caused by your InputStream. If you're not closing your InputStream, it can leak memory. If you want me to help, you'll need to come up with something that doesn't depend on your system.

[shaoneng111]

i use gperftools analyze the memory. it look like ffmpeg apply the av_malloc memory , is this means it leaks?

[shaoneng111]

hi, i find where is bug is. when FFmpegFrameGrabber input param is inputstream，it don't realease avformat and occurs memory leak. when i change FFmpegFrameGrabber input param from inputstream to file, memory leak disapears.

it look like avformat_free_context is invalid, should use avformat_close_input?

otherwise, in this issue : #911, someone has mensioned it, looks like the same problem with me.

[saudet]

Sounds like a fix. Please open a pull request!

[jetamie]

avio_context_free(avio) should be called here instead of av_free(avio) @saudet

[jetamie]

Maybe you need to call both

[Lwine]

hi, i find where is bug is. when FFmpegFrameGrabber input param is inputstream，it don't realease avformat and occurs memory leak. when i change FFmpegFrameGrabber input param from inputstream to file, memory leak disapears. it look like avformat_free_context is invalid, should use avformat_close_input?

otherwise, in this issue : #911, someone has mensioned it, looks like the same problem with me.

hello，i had the same problem.How did you reslove it?

[saudet]

@Lwine Thanks for the fix!

@shaoneng111 Please give it a try with the snapshots: http://bytedeco.org/builds/

[Love122]

How to fix this javacv 1.5.9 memory leak ? Base in javacv keep version 1.5.9,not change

[xiaobei2019]

@saudet
When will the 1.5.11 version be released to solve the memory leakage problem?
#2214

[saudet]

JavaCV 1.5.11 has been released and should fix this issue, but please let me know if you still have problems! Thanks

[saudet]

And thanks for @Lwine for the fix!