-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move doctest out to a dedicated job #8396
Conversation
97eb4a9
to
c4e4439
Compare
c4e4439
to
1233c8b
Compare
Comparing this with another run sampled historically I don't think there's any speedup? That matches my gut on this given the low core count of actions runners and how all our tests are internally parallel too. |
I'm seeing 15 vs 18 minutes for the Linux x64 run, though that's with the cached build of |
Never mind, @alexcrichton pointed out that this is due to not running the lldb tests on branches :) |
prtest:full
d681b39
to
1884ac5
Compare
Given that this isn't really speeding up testing, I don't think this is worth pursuing. If we decide to start partitioning tests onto different runners in the future it would be worth picking this back up, but without that the benefit just isn't there. |
1b38b78
to
90d8cee
Compare
4fbe153
to
2e73894
Compare
2e73894
to
6899805
Compare
OK, I've also concluded that it's not worth merging just the change to move the doctests out to a separate job, as it would only speed up CI on branches by about 2 minutes, and would have no effect on total merge time on main. It has the additional downside of ignoring any |
Move doctests out of individual tests by shadowing
rustdoc
when running./ci/run-tests.sh
, and explicitly run doctests only in their own dedicated job on anubuntu-latest
runner.