You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This fails to handle a pre-installed wasm-opt, and while it's perhaps a good balance for cargo install'd binaries this probably is the wrong balance for installation of this tool through other mechanisms. A build time config option should be added to enable usage of wasm-opt on PATH by default and/or disabling the download of precompiled binaries.
As brought up in #25 I think it's fine to pick any option as the default, since the main use case is the precompiled binaries on crates.io which we can always configure as we want on CI.
The text was updated successfully, but these errors were encountered:
Currently
wasm-opt
is run like so:WASM_OPT
is set, run thatThis fails to handle a pre-installed
wasm-opt
, and while it's perhaps a good balance forcargo install
'd binaries this probably is the wrong balance for installation of this tool through other mechanisms. A build time config option should be added to enable usage ofwasm-opt
onPATH
by default and/or disabling the download of precompiled binaries.As brought up in #25 I think it's fine to pick any option as the default, since the main use case is the precompiled binaries on crates.io which we can always configure as we want on CI.
The text was updated successfully, but these errors were encountered: