Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of locating wasm-opt #27

Open
alexcrichton opened this issue Nov 20, 2019 · 0 comments
Open

Improve handling of locating wasm-opt #27

alexcrichton opened this issue Nov 20, 2019 · 0 comments

Comments

@alexcrichton
Copy link
Member

Currently wasm-opt is run like so:

  • If WASM_OPT is set, run that
  • Otherwise, download a precompiled binary
  • If no precompiled binary exists, error

This fails to handle a pre-installed wasm-opt, and while it's perhaps a good balance for cargo install'd binaries this probably is the wrong balance for installation of this tool through other mechanisms. A build time config option should be added to enable usage of wasm-opt on PATH by default and/or disabling the download of precompiled binaries.

As brought up in #25 I think it's fine to pick any option as the default, since the main use case is the precompiled binaries on crates.io which we can always configure as we want on CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant