Locking a vault from the extension put the vault in an invalid state when trying to unlock it once more

[Oxalin]

From the extension, lock a vault. This will result in a throw of many error 500 in the extension's GUI (it is to be determined if this should be treated as an issue or if it all comes down to the desktop app). Even though the conneciton is still active, no vault will be available anymore.

On the application's side, the vault will be shown as locked (no more green dot on the right side of the tab).

However, if we try to unlock the vault once more, Buttercup will throw an error about the vault being in an invalid state.

The only workaround is to Quit the app and restart it.

[Oxalin]

There is something wrong the extension interacts with the app for locking and unlocking vaults. I discovered by running a few more tests that requesting to unlock a vault from the extension will properly pop up the Vault Unlock field, but even with a good password, an error will be thrown stating the unlocking source is in an invalid state (pending).

However, the vault is properly unlocked (green dot on tab and entries are visible), even though the Vault Unlock stays visible. And the extension will be able to access the vault's entries.

[perry-mitchell]

This looks like bad state on the extension side. Does it work if you change it once, close the browser menu and open it again, changing it then? I suspect that the locked/unlocked state is not updated.

It doesn't look like a desktop bug, at least from this cursory glance.

[Oxalin]

I'll have to investigate this a bit more. After updating Buttercup to 2.26.5 from 2.26.4, I can't reproduce it anymore.

[Oxalin]

I installed version 2.27.0 this morning and I just hit the bug once more. So it is still present. I'm beginning to understand how to reproduce it, but I'm not quite there yet. Here is a clue:

• Have the desktop app running in the background;
• Ask to unlock it from the extension, close the problematic empty popup in the desktop app but keep the main window opened (which will end up in the state reported here: Asking to unlock a vault from the extension while the desktop app is running in the background opens an empty Vault Unlock popup buttercup-browser-extension#487);
• Unlock the vault in the desktop app. You can then keep the main window opened or close it, the result will be the same;
• Ask to lock the vault from the extension;
• The extension will throw the 500 error.

However, I was unable to get the vault in a "pending" state in the desktop app yet.

Also, the first time I did this manoeuvre after updating to 2.27.0, once the error 500 was hit on the extension side after, the desktop app threw the following.

Then, no vaults were available in the desktop app and I had to restart it to be back on my feet. I was unable to reproduce this specific error afterward.