-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't load lubridate on startup + other upkeep #237
Conversation
…s, but actually load required packages separately hidden)
To avoid running the data-raw scripts again, save them in RDS file. #163. This avoids loading too many namespaces.
I also changed xlim and ylim so that the example doesn't show as blank. Do you know why the 75-125 lims are not correct anymore? eb5099a#diff-c53cfe3cb0db9e7cb411222ea0b11a7dd25ed649bd6e7ad9bce1b66f73abe0fc |
@mdancho84 let me know if you think these changes are too agressive! But I think there is an added value here as there are less messages on startup, and the new startup messages are more familiar for tidyversee users) |
Looks good to me. I felt it was an improvement and simplification. Plus fewer dependencies too. |
Let me know if you want to help out on some other things. Shoot me an email at [email protected] |
This should fix #116 , supersedes #163 (I think it's better to rely on cli's inline theme, rather than RStudio, as it makes the package more portable.
Using how tidyverse loads its packages rather than base R to create less clutter when loading the package.
Removing packages from depends
You will note that I tweaked the vignettes loading scheme.
Showing library(tidyverse), library(tidyquant)
actually running library(dplyr) library(lubridate) etc. library(tidyquant)
I also added
skip()
to avoid test failures when APIs are not available.Move
tq_performance()
andtq_transmute()
lists of functions into an internal data, as I assume that xts, quantmod are quite stable and if there are any new functions, it is always possible to re-run the data-raw script and update the possible functions.Addresses #235
Edit: closes #91