Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tough-cookie to v5 #1

Open
wojtekmaj opened this issue Sep 11, 2024 · 3 comments
Open

Update tough-cookie to v5 #1

wojtekmaj opened this issue Sep 11, 2024 · 3 comments

Comments

@wojtekmaj
Copy link

wojtekmaj commented Sep 11, 2024

v5 has been released:

https://github.com/salesforce/tough-cookie/releases/tag/v5.0.0

  • Removed psl dependency, removing Node.js 22 deprecation warnings
  • Rewritten in TypeScript, so no @types/tough-cookie needed anymore
@yap-paf
Copy link

yap-paf commented Nov 11, 2024

Yes, please update @kettanaito , it will remove DeprecationWarning: The punycode module is deprecated. Please use a userland alternative instead.

@kettanaito
Copy link
Collaborator

@yap-paf, the PR is open at mswjs/msw#2356. Needs some TS refactoring, new tough-cookie has breaking changes in types from what I can see.

@kettanaito
Copy link
Collaborator

Also, PRs to this mirror are still welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants