Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable dragging #292

Closed
wants to merge 2 commits into from
Closed

enable dragging #292

wants to merge 2 commits into from

Conversation

majodu
Copy link

@majodu majodu commented Jul 26, 2023

No description provided.

@beekhof
Copy link

beekhof commented Sep 17, 2023

@majodu I'd say this is unlikely to get merged given inclusion of so many orthogonal formatting changes (whitespace, brackets, quotes).

You're also missing d3-drag:d3from the rollup command.

@bumbeishvili are you interested in a minimal version of this PR that just adds drag-and-drop?

@bumbeishvili
Copy link
Owner

@beekhof I have an idea how to implement drag drop and would not merge other PRs with similar functionality . I have implemented it already in other private project and it certainly was not as simple as I would have imagined and I faced many issues.

That said, if you want to give it a go, feel free and I can link that PR to relevant issues to that people can have a temporary solution

@beekhof
Copy link

beekhof commented Sep 17, 2023

@bumbeishvili It took a bit of debugging, but PR #307 seemed to work for me. Happy to switch to someone else's version

@bumbeishvili
Copy link
Owner

Had a quick look. Not sure how it will behave in the new v3 version, since root.descendants() behaves differently and it only returns visible nodes (some nodes are hidden because of paging )

@riyasat-ali
Copy link

@beekhof How can we use that functionality of drag and drop for PR? Is there any Stackblitz or codesandbox for that?

@bumbeishvili

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants