You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Related to #464. (I think the underlying details have changed a bit since that issue was opened, and the new details point to us needing a new feature more than needing to fix a bug.)
As discussed in #464, we're currently not rendering a Profile Photo on the "Update Your Profile" page when we use ActiveStorage to handle the upload instead of Cloudinary.
The reason that shows up like it does is that when Cloudinary is not enabled we render a simple field partial.
I think that we really need a new type of field partial that is just image. And then inside the related partials we can do the checks for whether cloudinary is enabled.
That would mean that on user form we could eliminate the conditional and just do:
I think that developers for the most part shouldn't ever directly see cloudinary_enabled?, and it shouldn't be in most high-level templates.
We'll probably want to preserve the cloudinary_image field partials, for backwards compatibility, but we could probably just have them render the new image partial stuff.
The text was updated successfully, but these errors were encountered:
Related to #464. (I think the underlying details have changed a bit since that issue was opened, and the new details point to us needing a new feature more than needing to fix a bug.)
As discussed in #464, we're currently not rendering a Profile Photo on the "Update Your Profile" page when we use ActiveStorage to handle the upload instead of Cloudinary.
The reason that shows up like it does is that when Cloudinary is not enabled we render a simple field partial.
bullet_train-core/bullet_train/app/views/account/users/_form.html.erb
Lines 17 to 21 in 2b9dea3
I think that we really need a new type of field partial that is just
image
. And then inside the related partials we can do the checks for whether cloudinary is enabled.That would mean that on user form we could eliminate the conditional and just do:
I think that developers for the most part shouldn't ever directly see
cloudinary_enabled?
, and it shouldn't be in most high-level templates.We'll probably want to preserve the
cloudinary_image
field partials, for backwards compatibility, but we could probably just have them render the newimage
partial stuff.The text was updated successfully, but these errors were encountered: