Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trix indicator fillna value is wrong #283

Open
Hokyjack opened this issue Jan 22, 2022 · 1 comment
Open

Trix indicator fillna value is wrong #283

Hokyjack opened this issue Jan 22, 2022 · 1 comment

Comments

@Hokyjack
Copy link

Hello, there is probably an issue with Trix indicator, when used with fillna=True parameter,
it fills the missing value with 100, but I believe it should be 0, because then it is extreme value, that is never reached with this indicator. See image bellow:
image

@bukosabino
Copy link
Owner

Hi @Hokyjack ,

Thanks for your message.

TRIXIndicator and all the indicators that use ema internally have the same effect because the nan values are filled by pd.ewm. So let me study a solution for all the cases.

For the moment, try to work filling with the value that you prefer:

ta.trend.TRIXIndicator(all_symbols_preds_train["NEOUSDT"]["df_eval"]["close"], fillna=False).trix().fillna(0)

Best,
Dario

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants