Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better plugin checkout logging #3166

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DrJosh9000
Copy link
Contributor

@DrJosh9000 DrJosh9000 commented Jan 23, 2025

Description

Fixes #3090

Changes

  • Change the temp directory pattern to be less reminiscent of a plugin directory
  • Log the mktemp and mv operations similarly to the cd operation

To think about: these new logged operations should probably appear different on Windows 🤔

Testing

  • Tests have run locally (with go test ./...). Buildkite employees may check this if the pipeline has run automatically.
  • Code is formatted (with go fmt ./...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: plugin checkout dir printed incorrectly
1 participant