From bd7711c59e7a8e4c868640563637cc8852584c8f Mon Sep 17 00:00:00 2001 From: Maggie Lou Date: Wed, 11 Dec 2024 11:06:41 -0600 Subject: [PATCH] Remove linux go build constraint for uffd (#8042) We don't need the go build constraint because the BUILD file contains a `target_compatible_with` platform. This makes it easier to edit the file with an IDE, even on non-linux platforms This was originally added here https://github.com/buildbuddy-io/buildbuddy/pull/7965, then reverted due to the separate changes in that PR --- enterprise/server/remote_execution/uffd/BUILD | 19 ++++++++----------- .../server/remote_execution/uffd/uffd.go | 2 -- 2 files changed, 8 insertions(+), 13 deletions(-) diff --git a/enterprise/server/remote_execution/uffd/BUILD b/enterprise/server/remote_execution/uffd/BUILD index c0f8935e7d3..451590e8764 100644 --- a/enterprise/server/remote_execution/uffd/BUILD +++ b/enterprise/server/remote_execution/uffd/BUILD @@ -9,17 +9,14 @@ go_library( "@platforms//os:linux", ], visibility = ["//visibility:public"], - deps = select({ - "@io_bazel_rules_go//go/platform:linux": [ - "//enterprise/server/remote_execution/copy_on_write", - "//server/metrics", - "//server/util/log", - "//server/util/status", - "@com_github_prometheus_client_golang//prometheus", - "@org_golang_x_sys//unix", - ], - "//conditions:default": [], - }), + deps = [ + "//enterprise/server/remote_execution/copy_on_write", + "//server/metrics", + "//server/util/log", + "//server/util/status", + "@com_github_prometheus_client_golang//prometheus", + "@org_golang_x_sys//unix", + ], ) package(default_visibility = ["//enterprise:__subpackages__"]) diff --git a/enterprise/server/remote_execution/uffd/uffd.go b/enterprise/server/remote_execution/uffd/uffd.go index 67a67daefeb..3b2d37180e6 100644 --- a/enterprise/server/remote_execution/uffd/uffd.go +++ b/enterprise/server/remote_execution/uffd/uffd.go @@ -1,5 +1,3 @@ -//go:build linux && !android - package uffd import (