Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict allowed clippy warnings and errors #8435

Open
metaclips opened this issue Aug 31, 2024 · 1 comment
Open

Restrict allowed clippy warnings and errors #8435

metaclips opened this issue Aug 31, 2024 · 1 comment

Comments

@metaclips
Copy link
Member

Current behavior

After this PR is merged, we will be ignoring some clippy warnings in our codes, warnings include

  • #![allow(unexpected_cfgs)]
  • #![allow(clippy::unconditional_recursion)]

Desired behavior

We should check across all Rust codebase and fix all clippy warnings/errors that are being bypassed

@PanGan21
Copy link
Contributor

PanGan21 commented Sep 4, 2024

Hi! I was looking at this issue.
I removed both compiler attributes to get the warnings and see what needs to be fixed, but make lint_cargo_clippy didn't result to any warning.
How could I reproduce these warnings?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants