Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update required/ignore_empty behavior to match spec #46

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Update required/ignore_empty behavior to match spec #46

merged 1 commit into from
Nov 7, 2023

Conversation

rodaine
Copy link
Member

@rodaine rodaine commented Nov 7, 2023

Bringing the required and ignore_empty constraints into conformance.

See bufbuild/protovalidate#115

Alfus
Alfus approved these changes Nov 7, 2023
View reviewed changes
Copy link
Collaborator

@Alfus Alfus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@rodaine rodaine merged commit 6cc9f3e into main Nov 7, 2023
4 checks passed
@rodaine rodaine deleted the rodaine/require+ignore_empty branch November 7, 2023 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alfus Alfus Alfus approved these changes

@jchadwick-buf jchadwick-buf Awaiting requested review from jchadwick-buf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rodaine @Alfus