Apply new proto2 field presence and default values for optional fields as well #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timostamm
deleted the
tstamm/presence-and-default-values-for-proto2-optional-fields
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This widens #716 to support default values for proto2 optional fields as well, and applies the same technique to support field presence as for proto2 required fields.
Since the well-known types in
google/protobuf/descriptor.protoandgoogle/protobuf/plugin.protouse proto2, call sites in our descriptor wrappers and plugin-framework that distinguish between set/unset fields need to be updated to use the functions for field presence added in #717.