Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support option retention in @bufbuild/protoplugin #740

Closed
timostamm opened this issue Mar 6, 2024 · 3 comments
Closed

Support option retention in @bufbuild/protoplugin #740

timostamm opened this issue Mar 6, 2024 · 3 comments

Comments

@timostamm
Copy link
Member

Our plugin framework @bufbuild/protoplugin supports access to custom Protobuf options (see the documentation here). Currently, it does not support option retention yet (see the docs here, and the comments in plugin.proto).

We need to update @bufbuild/protoplugin to provide the descriptors that include RETENTION_SOURCE options so that users can access them when generating code. For users who do need the descriptors with stripped options (only RETENTION_RUNTIME), we have to provide alternate means.

@timostamm
Copy link
Member Author

Also see #701.

@timostamm
Copy link
Member Author

This was implemented in #827 for V2.

@timostamm
Copy link
Member Author

This is implemented in version 2.

Generated schemas do not include options with retention = RETENTION_SOURCE.

Schema.files from @bufbuild/protoplugin always includes all options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant