Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The problem of affine.parallel #194

Closed
EllisLambda opened this issue Sep 1, 2023 · 2 comments
Closed

The problem of affine.parallel #194

EllisLambda opened this issue Sep 1, 2023 · 2 comments

Comments

@EllisLambda
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Due to the difficulties in using affine.parallel, the outermost loop in the BatchMatMulOptimize of my PR does not utilize affine.parallel. However, this is crucial for the upcoming attempts to parallelize matmul using OpenMP. There's no open-source information available. I've tried writing code following the template, but it always results in errors

Describe the solution you'd like
Rewrite the outermost affine.for loop to affine.parallel

@xlinsist
Copy link
Collaborator

xlinsist commented Sep 2, 2023

Maybe we should follow this topic. Could you provide some code demos to further illustrate the technical background and difficulties?

BTW Here are some suggestions when creating an issue that you may follow:

  1. You can mention your PR by directly copying the link(whether it is from this repository or not) like this: [OpOptimization] Add BatchMatMul benchmark and [OpOptimization] Further optimize BatchMatMulBroadcast and add OpenMP tests buddy-benchmark#73.
  2. When you are seeking for a solution, try to avoid using ambiguous or unfocused naming of the title, make it spefific but not overly technical.

@EllisLambda
Copy link
Contributor Author

The problem have been solved. Thanks for the advice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants