From e6031ab9d99ee4dc224790d52d97a236714df75f Mon Sep 17 00:00:00 2001 From: Barrett LaFrance Date: Wed, 28 Aug 2024 11:31:44 -0500 Subject: [PATCH] chore: update --- .github/workflows/semrel-02-rel.yml | 2 ++ .github/workflows/semrel-rc.yml | 30 +++++++++++++++-------------- 2 files changed, 18 insertions(+), 14 deletions(-) diff --git a/.github/workflows/semrel-02-rel.yml b/.github/workflows/semrel-02-rel.yml index 1a7139307..8622cf992 100644 --- a/.github/workflows/semrel-02-rel.yml +++ b/.github/workflows/semrel-02-rel.yml @@ -16,6 +16,8 @@ on: jobs: rc: + permissions: + contents: write if: ${{ github.event_name == 'workflow_dispatch' || github.event.pull_request.merged == true }} uses: ./.github/workflows/semrel-rc.yml soak: diff --git a/.github/workflows/semrel-rc.yml b/.github/workflows/semrel-rc.yml index 9d45ad426..e34798609 100644 --- a/.github/workflows/semrel-rc.yml +++ b/.github/workflows/semrel-rc.yml @@ -7,19 +7,6 @@ on: workflow_call: # can be triggered by other workflows jobs: - # - name: upload image tar artifact - # uses: actions/upload-artifact@834a144ee995460fba8ed112a2fc961b36a5ec5a # v4.3.6 - # with: - # name: pepr-img.tar - # path: pepr-img.tar - # retention-days: 1 - - # - name: dowload image tar artifact - # uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8 - # with: - # name: pepr-img.tar - # path: ${{ github.workspace }} - check: runs-on: ubuntu-latest permissions: @@ -47,7 +34,7 @@ jobs: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} run: | needed=false - needle="There are no relevant changes, so no new version is released OOF." + needle="There are no relevant changes, so no new version is released." if $(npm run sem-rel -- --dry-run | tee >(cat 1>&2) | grep --quiet "$needle") then needed=false ; else needed=true @@ -68,6 +55,21 @@ jobs: echo "RELEASE_NEEDED=${{ needs.check.outputs.RELEASE_NEEDED }}" + + # - name: upload image tar artifact + # uses: actions/upload-artifact@834a144ee995460fba8ed112a2fc961b36a5ec5a # v4.3.6 + # with: + # name: pepr-img.tar + # path: pepr-img.tar + # retention-days: 1 + + # - name: dowload image tar artifact + # uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8 + # with: + # name: pepr-img.tar + # path: ${{ github.workspace }} + + # # TODO: works for steps... but what about stopping downstream jobs? #