Block hyphenated directory names for tests.

bstoll · Feb 27, 2024 · b86e534 · b86e534
1 parent 2b969b0
commit b86e534
Show file tree

Hide file tree

Showing 13 changed files with 10 additions and 4 deletions.
diff --git a/.github/workflows/pull_request.yml b/.github/workflows/pull_request.yml
@@ -17,6 +17,12 @@ jobs:
         find . -name \*.go -exec ./tools/check_ip_addresses.pl \{} +
     - name: Allowed File Types
       run: ./tools/allowed_file_types.sh
+    - name: Block hyphenated directory names
+      run: |
+      if ! find ./feature -type d -name '*-*' -print -exec false {} +; then
+        echo "Hyphenated directories are not allowed.  Please use a different separator like underscore."
+        exit 1
+      fi
     - name: Enum
       run: |
         fail=0

diff --git a/...ED_LocPref_prepend_flow-control/README.md → ...ED_LocPref_prepend_flow_control/README.md b/...ED_LocPref_prepend_flow-control/README.md → ...ED_LocPref_prepend_flow_control/README.md
diff --git a/..._MED_LocPref_prepend_flow_control_test.go → ..._MED_LocPref_prepend_flow_control_test.go b/..._MED_LocPref_prepend_flow_control_test.go → ..._MED_LocPref_prepend_flow_control_test.go
diff --git a/...f_prepend_flow-control/metadata.textproto → ...f_prepend_flow_control/metadata.textproto b/...f_prepend_flow-control/metadata.textproto → ...f_prepend_flow_control/metadata.textproto
diff --git a/...ybase/otg_tests/prefix-set_test/README.md → ...ybase/otg_tests/prefix_set_test/README.md b/...ybase/otg_tests/prefix-set_test/README.md → ...ybase/otg_tests/prefix_set_test/README.md
diff --git a/..._tests/prefix-set_test/metadata.textproto → ..._tests/prefix_set_test/metadata.textproto b/..._tests/prefix-set_test/metadata.textproto → ..._tests/prefix_set_test/metadata.textproto
diff --git a/...static-route_bgp_redistribution/README.md → ...static_route_bgp_redistribution/README.md b/...static-route_bgp_redistribution/README.md → ...static_route_bgp_redistribution/README.md
diff --git a/...sis/link-state-database/feature.textproto → ...sis/link_state_database/feature.textproto b/...sis/link-state-database/feature.textproto → ...sis/link_state_database/feature.textproto
diff --git a/...tatic-route_isis_redistribution/README.md → ...tatic_route_isis_redistribution/README.md b/...tatic-route_isis_redistribution/README.md → ...tatic_route_isis_redistribution/README.md
diff --git a/feature/isis/Weighted-ECMP/README.md → feature/isis/weighted_ECMP/README.md b/feature/isis/Weighted-ECMP/README.md → feature/isis/weighted_ECMP/README.md
diff --git a/...transceiver/ZR_pre-fec_ber_test/README.md → ...transceiver/ZR_pre_fec_ber_test/README.md b/...transceiver/ZR_pre-fec_ber_test/README.md → ...transceiver/ZR_pre_fec_ber_test/README.md
diff --git a/...ecn/otg_tests/DSCP-transparency/README.md → ...ecn/otg_tests/DSCP_transparency/README.md b/...ecn/otg_tests/DSCP-transparency/README.md → ...ecn/otg_tests/DSCP_transparency/README.md
diff --git a/testregistry.textproto b/testregistry.textproto
@@ -112,7 +112,7 @@ test: {
 test: {
   id: "DP-1.14"
   description: "DSCP transperency with ECN"
-  readme: "https://github.com/openconfig/featureprofiles/blob/main/feature/qos/ecn/otg_tests/DSCP-transparency/README.md"
+  readme: "https://github.com/openconfig/featureprofiles/blob/main/feature/qos/ecn/otg_tests/DSCP_transparency/README.md"
   exec: " "
 }
 test: {
@@ -262,7 +262,7 @@ test: {
 test: {
   id: "RT-1.27"
   description: "Static route to BGP redistribution"
-  readme: "https://github.com/openconfig/featureprofiles/blob/main/feature/bgp/static-route_bgp_redistribution/README.md"
+  readme: "https://github.com/openconfig/featureprofiles/blob/main/feature/bgp/static_route_bgp_redistribution/README.md"
   exec: " "
 }
 test: {
@@ -292,7 +292,7 @@ test: {
 test: {
   id: "RT-1.32"
   description: "BGP policy actions - MED, LocPref, prepend, flow-control"
-  readme: "https://github.com/openconfig/featureprofiles/feature/bgp/policybase/otg_tests/actions-MED_LocPref_prepend_flow-control/README.md"
+  readme: "https://github.com/openconfig/featureprofiles/feature/bgp/policybase/otg_tests/actions_MED_LocPref_prepend_flow_control/README.md"
   exec: " "
 }
 test: {
@@ -383,7 +383,7 @@ test: {
 test: {
   id: "RT-2.12"
   description: "Static route to IS-IS redistribution"
-  readme: "https://github.com/openconfig/featureprofiles/blob/main/feature/isis/static-route_isis_redistribution/README.md"
+  readme: "https://github.com/openconfig/featureprofiles/blob/main/feature/isis/static_route_isis_redistribution/README.md"
   exec: " "
 }
 test: {