Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

miniscript_string: crash with or_d(dv:0,0) #39

Open
brunoerg opened this issue Jun 17, 2024 · 2 comments
Open

miniscript_string: crash with or_d(dv:0,0) #39

brunoerg opened this issue Jun 17, 2024 · 2 comments
Labels

Comments

@brunoerg
Copy link
Owner

brunoerg commented Jun 17, 2024

or_d(dv:0,0) is sane for Bitcoin Core (IsSane() returns true) but fails for rust-miniscript due to "fragment «or_d(dv:0,0)» requires its left child be a unit (outputs exactly 1 given a satisfying input)".

@brunoerg brunoerg added the crash label Jun 17, 2024
@brunoerg
Copy link
Owner Author

friendly ping: @apoelstra

@apoelstra
Copy link

Neat. Yep, looks like d is supposed to be a unit in a Taproot context, but we have it unconditionally set to false.

This is actually likely to be a really annoying bug because currently our type properties do not know the script context.

cc @sanket1729

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants