Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spaces in executable name results in error #11

Open
Nikey646 opened this issue Aug 28, 2019 · 1 comment
Open

Spaces in executable name results in error #11

Nikey646 opened this issue Aug 28, 2019 · 1 comment

Comments

@Nikey646
Copy link

Nikey646 commented Aug 28, 2019

When you creating a project with a space in the name, it results in the docker run -it {tag} command failing due to this line not escaping the space correctly.

Test case:

$ mkdir "my app"
$ cd "my app"
$ dotnet new console

Adding the Dockerize tool to the .csporj

$ dotnet dockerize -t myapp
$ docker run -it myapp

produces the result of

/bin/sh: 1: /projectBinaries/my: not found

Manually modifying the dockerfile and rebuilding it to have an \ before any spaces results in the docker run command working as expected.

@brthor
Copy link
Owner

brthor commented Jul 30, 2020

Hey @Nikey646 I realize this was a while back, but this should be a straightforward fix in the code.

Feel free to make a PR if you are interested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants