-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Continuous development infrastructure for python #353
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerinphilip
added
the
experimental
Experimental stuff, might make it in might not
label
Feb 15, 2022
Change README.md to reflect wider capabilities (C++ library, Python, WebAssembly). Move a bulk of WebAssembly specific intructions to `wasm/README.md`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress.
This is an exploratory undertaking that attempts to add a missing piece to the python ecosystem provisioned from here. Not everything in this PR is expected to make in (hence marked as experimental). We are also going to use this as a "big" PR to attempt to add some useful features (tested) to be able to better shape the abstractions that repeat across tests.
The following enhancements are to be explored:
pytype
had been added for some static type-checking, which worked well. However, there are parts of the code we will need to know runs as intended and are covered by tests. For example, despite the existing checks stuff like Python bindings for alignment do not (yet?) work #352 went unnoticed. Towards this, we attempt to integratecoverage
(to measure how much of the python codebase our tests/runs cover) andpytest
(a framework to maintain tests) tentatively to the python subsystem.pytest
to solve some unit-test like checks reporting numbers for HTML feature (Continuous checks and evaluation of HTML translation feature #331, https://github.com/jerinphilip/tagtransfer/blob/master/tagtransfer/xml_eval.py).bergamot.REPOSITORY
object is intended to aggregate across multiple repositories and can be used to continuously test the models work as intended through the course of development here. A simple idea is to pass something like1 2 3 4 5 6 7 8 9
through all available models and assert a successful run as a smoke test. This should cover a lot of ground.Additional desiderata
(Tentatively) Fixes: #331, #352