Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

version check issues? #502

Closed
johnstonskj opened this issue Apr 19, 2023 · 4 comments · Fixed by emacs-rustic/rustic#48 · May be fixed by #570
Closed

version check issues? #502

johnstonskj opened this issue Apr 19, 2023 · 4 comments · Fixed by emacs-rustic/rustic#48 · May be fixed by #570

Comments

@johnstonskj
Copy link

When I run rustic-doc-setup I get the following messages:

Your version of fd is too old, please install a recent version, maybe through cargo.
Your version of pandoc is too old, please install a more recent version. See their github for more info.

However I have both installed by brew on macos and have done specific upgrades to both to get them to the latest versions:

❯ pandoc --version
pandoc 3.1.2
❯ fd --version
fd 8.7.0
@IT-Luka
Copy link

IT-Luka commented Jun 30, 2023

Doom Emacs,

When running rustic-doc-setup through M-x:

Your version of pandoc is too old, please install a more recent version. See their github for more info.

I've tried it with version 3.1.2 (newest on arch), and 3.1.4 (newest on github), same result

Running (rustic-doc-setup) in ielm or eshell also gives this error:

Symbol’s function definition is void: rustic--inheritenv

@whompyjaw
Copy link

I am getting the same issue using Doom Emacs. Using 3.1.7 of pandoc (newest version per their github)

@Padswynn
Copy link

Same problem:

GNU Emacs 29.3
Copyright (C) 2024 Free Software Foundation, Inc.
GNU Emacs comes with ABSOLUTELY NO WARRANTY.
You may redistribute copies of GNU Emacs
under the terms of the GNU General Public License.
For more information about these matters, see the file named COPYING.

pandoc 3.1.3
Features: -server +lua
Scripting engine: Lua 5.4
User data directory: /home/username/.local/share/pandoc
Copyright (C) 2006-2023 John MacFarlane. Web: https://pandoc.org
This is free software; see the source for copying conditions. There is no
warranty, not even for merchantability or fitness for a particular purpose.

rustup 1.27.1 (54dd3d00f 2024-04-24)
info: This is the version for the rustup toolchain manager, not the rustc compiler.
info: The currently active `rustc` version is `rustc 1.78.0 (9b00956e5 2024-04-29)`

fd 10.1.0

I have tried buildign pandoc from source to get to a more recent version, but nothing is working.

full error that i get:

Your version of fd is too old, please install a recent version, maybe through cargo.
Your version of pandoc is too old, please install a more recent version. See their github for more info.
rustic-doc--start-process: Invalid function: rustic--inheritenv
Could not finish process: exited abnormally with code 1

I would like to add that I have tried with fd-find being intalled by my package manager and by cargo. When I install FD through cargo it gives the above error, however the fd is too old line is gone when fd-find is installed through distro repository.

@Velnbur
Copy link

Velnbur commented Jul 8, 2024 •
edited
Loading

From code I see this issue is not related to fd and/or pandoc at all:

rustic/rustic-doc.el

Line 282 in 39423d1

(substring (shell-command-to-string "fd --version") 3 4)))

For some reason only the minor version of fd is checked. To prove that, after running this line, I get:

$ fd --version
fd 10.1.0

And after running elisp code:

(substring (shell-command-to-string "fd --version") 3 4) => "1"

The same thing with pandoc:

rustic/rustic-doc.el

Line 286 in 39423d1

(substring (shell-command-to-string "pandoc --version") 9 11))) 

$ pandoc --version
pandoc 3.1.11.1
Features: +server +lua
Scripting engine: Lua 5.4
User data directory: /Users/velnbur/.local/share/pandoc
Copyright (C) 2006-2023 John MacFarlane. Web: https://pandoc.org
This is free software; see the source for copying conditions. There is no
warranty, not even for merchantability or fitness for a particular purpose.
(substring (shell-command-to-string "pandoc --version") 9 11) => "1."

@Velnbur Velnbur mentioned this issue Jul 8, 2024
Open
@Velnbur Velnbur mentioned this issue Sep 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@johnstonskj @whompyjaw @Velnbur @Padswynn @IT-Luka