Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using the DELETE functionality is now only possible with supplied body #105

Open
stefan-kolb opened this issue May 18, 2016 · 1 comment

Comments

@stefan-kolb
Copy link
Contributor

Introduced by d8a515e.

-  def delete(url, headers = nil)
-    @response = make_request(:delete, url, headers: headers)
+  def delete(url, delete_body = nil, headers = nil)
+    @response = make_request(:delete, url, body: delete_body, headers: headers)
    end

Is this really wanted? Shouldn't there be an option to only supply headers as with get requests?
Btw, this change took me hours to find out why my headers were not passed correctly/missing as with v0.1 (also motivates #104).

@MariusJorgensen
Copy link

This was driving me nuts as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants