From 9c7fbe71d26ada1e03857401d799b6d35d6fc23a Mon Sep 17 00:00:00 2001 From: Alexis Date: Wed, 20 May 2020 15:51:34 -0500 Subject: [PATCH] Added periods --- pr_templates/data_modeling_pr.md | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/pr_templates/data_modeling_pr.md b/pr_templates/data_modeling_pr.md index 80b6ca7..dc1d7d3 100644 --- a/pr_templates/data_modeling_pr.md +++ b/pr_templates/data_modeling_pr.md @@ -1,22 +1,22 @@ ## Overview -_Summarize the goal of your work and what motivated it_ +_Summarize the goal of your work and what motivated it._ ## Key changes -- _Describe major updates_ +- _Describe major updates._ ## Other notes -- _List open questions and other things your reviewer should know_ +- _List open questions and other things your reviewer should know._ ## Related links -- _List links to related ticket(s)_ -- _(optional) Link to other files and resources, such as specific related reports in a BI tool_ +- _List links to related ticket(s)._ +- _(optional) Link to other files and resources, such as specific related reports in a BI tool._ ## Checklist -- [ ] All models, whether directly changed by this PR or not, run successfully -- [ ] New code follows [dbt coding conventions](https://github.com/brooklyn-data/co/blob/master/dbt_coding_conventions.md) and [SQL style guide](https://github.com/brooklyn-data/co/blob/master/sql_style_guide.md) +- [ ] All models, whether directly changed by this PR or not, run successfully. +- [ ] New code follows [dbt coding conventions](https://github.com/brooklyn-data/co/blob/master/dbt_coding_conventions.md) and [SQL style guide](https://github.com/brooklyn-data/co/blob/master/sql_style_guide.md). - [ ] Testing: - - [ ] All added/modified models and columns are documented and tested in `schema.yml` files - - [ ] All tests pass **OR** + - [ ] All added/modified models and columns are documented and tested in `schema.yml` files. + - [ ] All tests pass. **OR** _Check one:_ - - [ ] There are no new test failures, whether or not the existing model was intentionally changed for this PR - - [ ] This PR causes new test failures and there is a plan in place for addressing them + - [ ] There are no new test failures, whether or not the existing model was intentionally changed for this PR. + - [ ] This PR causes new test failures and there is a plan in place for addressing them.