Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IntervalListToolsTest.testScatterByContent and IntervalListToolsTest.testScatter could use some improvement #1795

Open
kachulis opened this issue Apr 7, 2022 · 0 comments

Comments

@kachulis
Copy link
Contributor

kachulis commented Apr 7, 2022

The tests IntervalListToolsTest.testScatterByContent and IntervalListToolsTest.testScatter are a bit brittle in that they make an assumption that the transformation between scatter count and scatter content is bijective, which it is not. I believe that the previous test data has only passed due to using examples where the reversibility is preserved. However, it is relatively easy to construct reasonable test data where this bijectivity is broken and one or the other of the tests will fail. This led to a bit of a messy work around in #1786, but would be better to improve the way the tests are written to avoid this pitfall.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant