Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid creating a container element for each tooltip #44

Open
nawatts opened this issue Feb 3, 2021 · 0 comments
Open

Avoid creating a container element for each tooltip #44

nawatts opened this issue Feb 3, 2021 · 0 comments

Comments

@nawatts
Copy link
Contributor

nawatts commented Feb 3, 2021

Currently, the TooltipAnchor component attaches a container element to the body and render its tooltip into that container.

constructor(props) {
super(props)
this.containerElement = document.createElement('div')
}
componentDidMount() {
document.body.appendChild(this.containerElement)
}
componentWillUnmount() {
document.body.removeChild(this.containerElement)
}

This affects performance when rendering many elements with tooltips, such as some plots. Preferably, all tooltip anchors could share one container.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant