Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch for issue with cache classes = false, stackoverflow #4

Open
banane opened this issue Dec 30, 2009 · 1 comment
Open

patch for issue with cache classes = false, stackoverflow #4

banane opened this issue Dec 30, 2009 · 1 comment

Comments

@banane
Copy link

banane commented Dec 30, 2009

Hi-
I have a patch that colleagues and I worked on. How do you want me to add it to the repo? The way we fixed:

In the tax_extensions.rb, added an "unless" condition around the alias_method_chain. The problem was- it would endlessly re-load the "children_find_options_without_drag_order" in certain situations. With config.cache_classes = false, and children:each tags, and in some installed gems/versions. The condition just checks as to whether the private class has been defined before doing the alias-chain.

base.private_method_defined?(:children_find_options_with_drag_order)

cheers
Anna

@banane
Copy link
Author

banane commented Dec 30, 2009

I've also included the fix in my fork- that also has some UI stuff, so wasn't sure if folks wanted to merge that or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant