Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: adding keep_files: [".git"] config option prevents _bridgetown folder from being created #624

Open
whysthatso opened this issue Sep 12, 2022 · 1 comment · May be fixed by #945
Open

bug: adding keep_files: [".git"] config option prevents _bridgetown folder from being created #624

whysthatso opened this issue Sep 12, 2022 · 1 comment · May be fixed by #945
Labels
bug Something isn't working
Milestone
2.0

Comments

@whysthatso
Copy link

when adding this line:
keep_files: [".git"]
to bridgetown.config.yml

the subdirectory _bridgetown is not being created, and static files are not available. however, there is no error in the log output, esbuild functions normally and creates the files.

Bridgetown Version:
1.1.0

To Reproduce

  • generate vanilla project bridgetown new demo -t erb
  • add keep_files: [".git"] to bridgetown.config.yml
  • run bin/bt start
  • confirm folder _bridgetown is not existing
  • confirm log shows no errors

Log output

[Bridgetown]           Starting: Bridgetown v1.1.0 (codename "Belmont")
[Server] * Puma version: 5.6.4 (ruby 3.1.2-p20) ("Birdie's Version")
[Server] * PID: 11501
[Server] * Listening on http://0.0.0.0:4001
[Server] Use Ctrl-C to stop
[Frontend] yarn run esbuild-dev
[Frontend] yarn run v1.22.19
[Frontend] $ node esbuild.config.js --watch
[Frontend] esbuild: frontend bundling started...
[Bridgetown]        Environment: development
[Bridgetown]             Source: /home/andreas/resilio/projects/wellpress_site/bulma_fresh/src
[Bridgetown]        Destination: /home/andreas/resilio/projects/wellpress_site/bulma_fresh/output
[Bridgetown]     Custom Plugins: /home/andreas/resilio/projects/wellpress_site/bulma_fresh/plugins
[Bridgetown]         Generating… 
[Frontend] esbuild: frontend bundling complete!
[Frontend] esbuild: entrypoints processed:
[Frontend]          - index.CY6HFAGO.js: 238.89KB
[Frontend]          - index.OKYRN2M2.css: 279.83KB
[Bridgetown]         Pagination: disabled. Enable in site config with pagination:\n enabled: true
[Bridgetown]             Done! 🎉 Completed in less than 0.55 seconds.
[Bridgetown]                     
[Bridgetown]     Now serving at: http://localhost:4000

Computing environment (please complete the following information):

  • OS: linux
  • Ruby Version: ruby 3.1.2p20 (2022-04-12 revision 4491bb740a) [x86_64-linux]
@whysthatso whysthatso added the bug Something isn't working label Sep 12, 2022
@jaredcwhite jaredcwhite added this to the 1.2 milestone Sep 23, 2022
@jaredcwhite jaredcwhite modified the milestones: 1.2, 1.3 Jan 25, 2023
@jaredcwhite jaredcwhite modified the milestones: 1.3, 1.4 Jul 31, 2023
@jaredcwhite jaredcwhite modified the milestones: 1.4, 2.0 Feb 17, 2024
@jaredcwhite
Copy link
Member

Ran into this again, looks like we need to merge _bridgetown into whatever custom setting a user might specify.

@jaredcwhite jaredcwhite linked a pull request Nov 23, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
2.0
Development

Successfully merging a pull request may close this issue.

Preserve the _bridgetown default value in keep_files config bridgetownrb/bridgetown
2 participants
@jaredcwhite @whysthatso