Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong plugins list command count #770

Open
akarzim opened this issue Jun 17, 2023 · 0 comments · May be fixed by #771
Open

Wrong plugins list command count #770

akarzim opened this issue Jun 17, 2023 · 0 comments · May be fixed by #771
Labels
bug Something isn't working

Comments

@akarzim
Copy link
Contributor

akarzim commented Jun 17, 2023

When running bin/bridgetown plugins list command, the registered plugins count is wrong.

Bridgetown Version: 1.2.0

To Reproduce

  1. Start a new Bridgetown project
  2. run bin/bridgetown plugins list

Current behavior

init (Initializer) is excluded from the list of registered plugins, but is included in the plugin count.

❯ bin/bridgetown plugins list
Registered Plugins: 4
                    dotenv (Initializer)
                    parse_routes (Initializer)
                    ssr (Initializer)
          Builders: 0
                    ----
        Converters: 6
                    Bridgetown::Converters::SerbeaTemplates
                    Bridgetown::Converters::RubyTemplates
                    Bridgetown::Converters::LiquidTemplates
                    Bridgetown::Converters::ERBTemplates
                    Bridgetown::Converters::Markdown
                    Bridgetown::Converters::Identity
                    ----
        Generators: 2
                    Bridgetown::PrototypeGenerator
                    Bridgetown::Paginate::PaginationGenerator

Expected behavior

init (Initializer) must be excluded from the plugin count.

❯ bin/bridgetown plugins list
Registered Plugins: 3
                    dotenv (Initializer)
                    parse_routes (Initializer)
                    ssr (Initializer)
          Builders: 0
                    ----
        Converters: 6
                    Bridgetown::Converters::SerbeaTemplates
                    Bridgetown::Converters::RubyTemplates
                    Bridgetown::Converters::LiquidTemplates
                    Bridgetown::Converters::ERBTemplates
                    Bridgetown::Converters::Markdown
                    Bridgetown::Converters::Identity
                    ----
        Generators: 2
                    Bridgetown::PrototypeGenerator
                    Bridgetown::Paginate::PaginationGenerator

Computing environment (please complete the following information):

  • OS: macOS 11.7.7 (Big Sur)
  • Browser: Firefox
  • Browser Version: 114.0.1
  • Ruby Version: ruby 3.2.2 (2023-03-30 revision e51014f9c0) [x86_64-darwin20]
@akarzim akarzim added the bug Something isn't working label Jun 17, 2023
@akarzim akarzim linked a pull request Jun 17, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP: Exclude init initializer from plugins list command count akarzim/bridgetown
1 participant
@akarzim