You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm curious to get your guys feedback. In Firefox 22, 25 if the user has the privacy option "remember history" set to "never remember history" then IndexedDB will throw a "InvalidStateError" when trying to call open on window.indexedDB.
It's an asynchronous exception that can't be caught using try ... catch. The only reasonable way to test if the IndexedDB adapter is valid is by trying to open the DB which is an async process.
The problem is that the Lawnchair valid API is synchronous. (It's built into the Lawnchair constructor which I guess is why it is async).
The only proper option I see to fix this is refactor the Lawnchair API such that the valid method is called asynchronously.
BTW this bug has the nasty side-effect of causing the IndexedDB adapter to infinite-error-loop between:
I'm planning to patch the infinite-loop locally and just not use Lawnchair if this scenario arises but it's certainly not-ideal. Lawnchair should fall back to a different adapter if one isn't available.
The text was updated successfully, but these errors were encountered:
the bug you're seeing occurs when you're trying to fire up an indexed db when you set firefox to private mode or set it to not remember the history. please check if this helps: #207
I'm curious to get your guys feedback. In Firefox 22, 25 if the user has the privacy option "remember history" set to "never remember history" then IndexedDB will throw a "InvalidStateError" when trying to call
open
onwindow.indexedDB
.It's an asynchronous exception that can't be caught using
try ... catch
. The only reasonable way to test if the IndexedDB adapter is valid is by trying to open the DB which is an async process.The problem is that the Lawnchair
valid
API is synchronous. (It's built into the Lawnchair constructor which I guess is why it is async).The only proper option I see to fix this is refactor the Lawnchair API such that the
valid
method is called asynchronously.BTW this bug has the nasty side-effect of causing the IndexedDB adapter to infinite-error-loop between:
https://github.com/brianleroux/lawnchair/blob/master/src/adapters/indexed-db.js#L54
and
https://github.com/brianleroux/lawnchair/blob/master/src/adapters/indexed-db.js#L122-L126
I'm planning to patch the infinite-loop locally and just not use Lawnchair if this scenario arises but it's certainly not-ideal. Lawnchair should fall back to a different adapter if one isn't available.
The text was updated successfully, but these errors were encountered: