Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Height does not get updated with aboveStatusBar={true} #3

Closed
mbrgm opened this issue May 19, 2015 · 5 comments
Closed

Height does not get updated with aboveStatusBar={true} #3

mbrgm opened this issue May 19, 2015 · 5 comments

Comments

@mbrgm
Copy link

mbrgm commented May 19, 2015

For some reason the overlay is exactly 64px too small. If I manually set bottom: -64px in Overlay.ios.js, the overlay fills the screen, but otherwise it is not large enough. I checked the height of the UIView and it seemed to be correct -- so I suppose the error is somewhere in the JS. Maybe the view gets laid out before the UIView has the full height?

@mbrgm
Copy link
Author

mbrgm commented May 19, 2015

I did some experiments and the overlay works when placed in a component with full screen height, but not otherwise:

+-----------------------------------------------+
|                                               |
|-----------------------------------------------|
|                                               |
|-----------------------------------------------|
|             owning component                  |
+-----------------------------------------------+
  • aboveStatusBar = true and isVisible = true from the start, it will remain below the other two components
  • aboveStatusBar = true and isVisible becomes true at a later point in time, it will be placed at the top of the screen, but its height will stay as if it was placed within its owning component (aboveStatusBar = false)

Hope this helps!

@niftylettuce
Copy link
Collaborator

Possibly related to #4, did you fix? @mbrgm

@mbrgm
Copy link
Author

mbrgm commented Jan 10, 2016

I switched from RN to native development for several other reasons, so I won't be able to check, sorry :-/.

@niftylettuce
Copy link
Collaborator

See #36 - we will be refactoring this soon to support Android/iOS and not have any issues here, there will no longer be the XCode integration needed

@mbrgm
Copy link
Author

mbrgm commented Jan 13, 2016

I'll close this as it is not an issue for me anymore and I won't be able to check whether it's resolved anyway. Feel free to reopen if you disagree. :)

@mbrgm mbrgm closed this as completed Jan 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants