Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support incoming chain swap under/overpayment #632

Open
danielgranhao opened this issue Dec 26, 2024 · 3 comments
Open

Support incoming chain swap under/overpayment #632

danielgranhao opened this issue Dec 26, 2024 · 3 comments
Milestone

Comments

@danielgranhao
Copy link
Contributor

An incoming chain swap for which an amount was specified but was over or underpaid, as long as the amount is within the min and max swap limits, can be treated as a zero-amount swap. This means that it doesn't have to be refunded. The payment can be completed if a new quote is fetched and accepted.

@danielgranhao
Copy link
Contributor Author

In several areas of the codebase, the term "amount less" or "zero amount" swap is used. These can and should be generalized as they apply to the use case mentioned above.

@roeierez roeierez added this to the Next Release milestone Jan 9, 2025
@roeierez
Copy link
Member

Discussed that with @kingonly and not sure this should be in priority currently.
The reason is because now that we have amount-less swaps probably it is going to be the main use case and using swaps with amount perhaps will be for cases where the amount is important (e.g user is expecting an exact amount).
@danielgranhao if you agree let's hold it for now.

@danielgranhao
Copy link
Contributor Author

@roeierez SGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants