Thanks @danielgranhao.
If we are changing the ReveseSwapInfo then let's also add the payment_hash so users can use payment_by_hash method to retrieve the associated payment.

Working on exposing the reverse swap fees.
I can add the fees for any new reverse swap, but not existing ones, because we don't have the data.

I was thinking about backfilling the fees for the existing swaps by looking at onchain transaction fees. But the tx ids are only persisted in the local storage, not the sync storage. So this data is lost when you lose your local data.

So a 2-fold question to @danielgranhao and @roeierez:

• Is having the fees only for new swaps good enough?
• It seems to me like we should store the claim and lockup tx ids in the sync database, why are they in the local database only? (it was added in this PR Include ReverseSwapInfo in Payment #728)

@JssDWt moving forward without backfilling the old swaps is fine enough IMO for this PR.
The lockup/claim tx are not synced because they are onchain data that is fetched from the blockchain.

I've just noticed I created another version of this issue earlier. It's almost an exact duplicate, but it also asks to add the recipient onchain address to ReverseSwapInfo. I still think it would be useful.