From 68aa1d003944a6d75f99bf6c6f30da03e070bbce Mon Sep 17 00:00:00 2001
From: yse <70684173+hydra-yse@users.noreply.github.com>
Date: Thu, 8 Aug 2024 14:35:33 +0200
Subject: [PATCH] fix (sdk-common): add missing character to bip21 uri (#1068)

---
 libs/sdk-common/src/input_parser.rs | 2 +-
 libs/sdk-common/src/liquid/bip21.rs | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/libs/sdk-common/src/input_parser.rs b/libs/sdk-common/src/input_parser.rs
index 84061fc89..676279a8a 100644
--- a/libs/sdk-common/src/input_parser.rs
+++ b/libs/sdk-common/src/input_parser.rs
@@ -634,7 +634,7 @@ impl BitcoinAddressData {
                     .map(|(key, value)| format!("{key}={value}"))
                     .collect::<Vec<String>>()
                     .join("&");
-                Ok(format!("{scheme}:{}{suffix_str}", self.address))
+                Ok(format!("{scheme}:{}?{suffix_str}", self.address))
             }
         }
     }
diff --git a/libs/sdk-common/src/liquid/bip21.rs b/libs/sdk-common/src/liquid/bip21.rs
index 2b5e1a603..9a509b11e 100644
--- a/libs/sdk-common/src/liquid/bip21.rs
+++ b/libs/sdk-common/src/liquid/bip21.rs
@@ -65,7 +65,7 @@ impl LiquidAddressData {
                     .collect::<Vec<String>>()
                     .join("&");
 
-                Ok(format!("{scheme}:{}{suffix_str}", self.address))
+                Ok(format!("{scheme}:{}?{suffix_str}", self.address))
             }
         }
     }