Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UpsidePotentialRatio missing r when MAR is time series #185

Open
Javdat opened this issue Jul 23, 2023 · 0 comments
Open

UpsidePotentialRatio missing r when MAR is time series #185

Javdat opened this issue Jul 23, 2023 · 0 comments

Comments

@Javdat
Copy link

Javdat commented Jul 23, 2023

UpsidePotentialRatio fails when MAR is specified as time series:

> UpsidePotentialRatio(managers, MAR = managers$`US 10Y TR`)
Error in FUN(newX[, i], ...) : object 'r' not found

The issue is due to returns being specified as r instead of R
https://github.com/braverock/PerformanceAnalytics/blob/49a93f1ed6e2e159b63bf346672575f3634ed370/R/UpsidePotentialRatio.R#L91C31-L91C31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant