Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passwords saved on Desktop before joining the sync are self-removed from Android when Android device is deleted from the sync chain #43296

Open
3 of 6 tasks
hffvld opened this issue Jan 15, 2025 · 0 comments
Assignees
Labels
bug feature/password-manager feature/sync OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes

Comments

@hffvld
Copy link
Contributor

hffvld commented Jan 15, 2025

Description

Passwords saved on Desktop before joining the sync are self-removed from Android when the Android device is removed from the sync chain or when the whole sync chain is deleted. If just the Desktop device is removed from the sync chain, passwords are not self-removed on the Android device since the sync chain still exists on that device.

Steps to reproduce

  1. Launch the latest version of Brave on Desktop
  2. Go to Settings > Sync > Create new or use existing sync chain
  3. Make sure that Sync everything is ON to sync passwords
  4. Go to any website where you can sign in to the account and save login credentials, for example, https://adobe.com
  5. Save login credentials when prompted
  6. Go to the Settings > Password manager > Confirm that the password is saved
  7. Launch Brave with Cr131 on Android (I used Brave 1.73.100)
  8. Go to the Settings > Sync > Confirm that the Sync is OFF
  9. Close the settings > Go to any website where you can sign in to the account and save login credentials, for example, https://feedly.com
  10. Save login credentials when prompted
  11. Go to the Settings > Password manager > Confirm that the password is saved
  12. Add Android device to an existing sync chain
  13. Tap Sync everything to sync passwords
  14. Go to the Password Manager on both devices > Confirm that all passwords are synced across all devices
  15. Remove Android device from the Sync chain or Delete whole Sync chain on any of these devices
  16. Go to Password manager > Observe that the passwords that were created on Desktop are removed from Android now
  17. Upgrade Brave on Android to a newer version with Cr132
  18. Repeat steps 7 - 16 > Observe that the upgrade didn't resolve the issue

Actual result

Passwords saved on Desktop before joining the sync are self-removed from Android when the Android device is deleted from the sync chain.

This issue is reproducible with Cr131 and Cr132.


2025-01-14_15-18-08.mp4

Expected result

Passwords must not disappear if the device is removed from the sync chain or if the sync chain is deleted.

Reproduces how often

Easily reproduced

Brave version

Brave build: 1.76.13
Chromium: 132.0.6834.83 (Official Build) canary (64-bit)

Device

  • Brand/Model: ANY
  • Android version: 14, 15

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response

@hffvld hffvld added bug feature/password-manager feature/sync OS/Android Fixes related to Android browser functionality QA/Yes labels Jan 15, 2025
@deeppandya deeppandya added the priority/P2 A bad problem. We might uplift this to the next planned release. label Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/password-manager feature/sync OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes
Projects
None yet
Development

No branches or pull requests

3 participants