Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update list of licenses for adblock lists #29346

Closed
fmarier opened this issue Mar 27, 2023 · 3 comments · Fixed by brave/brave-core#17786
Closed

Update list of licenses for adblock lists #29346

fmarier opened this issue Mar 27, 2023 · 3 comments · Fixed by brave/brave-core#17786

Comments

@fmarier
Copy link
Member

fmarier commented Mar 27, 2023

We need to ensure that all of the lists we use in https://github.com/brave/adblock-resources/tree/master/filter_lists are disclosed in brave://credits.

@fmarier fmarier added QA/Yes release-notes/exclude OS/Android Fixes related to Android browser functionality licensing OS/Desktop labels Mar 27, 2023
@fmarier fmarier self-assigned this Mar 27, 2023
fmarier added a commit to brave/brave-core that referenced this issue Mar 28, 2023
@fmarier
Copy link
Member Author

fmarier commented Mar 28, 2023

The better way to solve this and ensure that the data is never out-of-date is to move the licensing info to the component.

In the meantime, we'll just make sure the list is up-to-date.

@stephendonner
Copy link

Verified PASSED using

Brave 1.51.77 Chromium: 112.0.5615.49 (Official Build) beta (x86_64)
Revision bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
OS macOS Version 13.4 (Build 22F5027f)

Steps:

  1. installed 1.51.77
  2. launched Brave
  3. opened brave://credits
  4. scrolled down
  5. searched for blocklists

Confirmed no errors, and the updated license content for Blocklists Anti-porn list and others, is in

Screenshot 2023-04-04 at 3 42 07 PM

@GeetaSarvadnya
Copy link

Verification PASSED on Vivo X70 Pro version 12 running Bravemonoarm64.apk_1.51.105

Confirmed no errors, and the updated license content for Blocklists Anti-porn list and others, is in

Screenshot_20230427_165711

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants