Skip to content
This repository has been archived by the owner on Dec 12, 2018. It is now read-only.

Dynamic production and verbose variables #62

Open
NejcZdovc opened this issue Aug 31, 2018 · 1 comment
Open

Dynamic production and verbose variables #62

NejcZdovc opened this issue Aug 31, 2018 · 1 comment
Assignees

Comments

@NejcZdovc
Copy link
Contributor

Flags shouldn't be static, we should be able to set them via setters. In client we would do that via flags

@NejcZdovc
Copy link
Contributor Author

for verbose mode let's do macro for vlog so we can trigger it the same way as we do it in core brave/brave-core@0a582df#diff-a5d16be9c9b52a6df7b866b1d75d3f5fR496

for production flag we should be able to provide flag when doing npm run start. If flag is not provided default value should be production

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants