-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement ETag & Last-modified #70
Comments
Will have a look at that. From the first glance it seems to be incompatible with folder mode since it needs to store data per note in the database? |
Afaik, the notes app is using files. I'll dig a bit into it later. |
Well, they now also use a database for metadata. Maybe thats something we could live with. |
Would want do clone the notes repo anyways to see how the resolved "$note->getId()" in case only files are used. Not sure where you would store an id in that case... |
|
Yes, have seen that. Its somehow info stored by nextcloud along with the file. So it should be relatively easy to retrieve it for a file and (hopefully) also find the file for an id :-) |
BTW, how could this be easily tested once added as feature? I don't know to much about testing in such an environment... |
I think if we follow this:
It should be fine, otherwise i hope that @korelstar could help a bit out. |
Long time no progress here. By now I have managed to upgrade my NAS so that its fast enough for development & testing. I would think this is a feature to add after v1.0 is ready? Stable first - fast later :-) Or is that an essential feature right away? |
This will greatly speed up the api.
For reference we can use this.
Shouldn't be too difficult.
@ThomasDaheim Want to give this a try? If you want to, make sure you branch of the
master
branch.cc @korelstar Can you guide us along the way?
The text was updated successfully, but these errors were encountered: