Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Use Sass modules instead of global built-in functions #20

Open
TiLodoss opened this issue Nov 17, 2024 · 0 comments
Open

Comments

@TiLodoss
Copy link

First of all, thanks a lot for this lib, it's really nice and simple to use 🎉

While using it in a project that runs with Node 22 and sass 1.80, many deprecating warnings like (the one below) were fired.

Deprecation Warning: Global built-in functions are deprecated and will be removed in Dart Sass 3.0.0.
Use string.index instead.

More info and automated migrator: https://sass-lang.com/d/import

    ╷
132 │                 $index: str-index($string, $search);

I took the liberty to clone the project and I've fixed the warning ny using sass' modules. However, I am not able to create a PR since I'm not able to push a new branch. I'm kinda a contributor newbie 😅

Let me know if you would like to see the modifications I've made.

Cheers!

@TiLodoss TiLodoss changed the title [Improvement] Usage Sass modules instead of global built-in functions [Improvement] Use Sass modules instead of global built-in functions Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant