Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mock Test Data #8

Open
brandonmanke opened this issue Aug 23, 2018 · 0 comments
Open

Mock Test Data #8

brandonmanke opened this issue Aug 23, 2018 · 0 comments
Labels
proposal question unit-tests

Comments

@brandonmanke
Copy link
Owner

brandonmanke commented Aug 23, 2018 •
edited
Loading

Description

Currently our tests completely rely on the destiny 2 API to run. This isn't the best idea since our tests can fail randomly depending on network conditions. We should try to convert all of our tests that rely on the destiny API to mocked response data. This might be fairly difficult since there is so much we have to mock. However it will improve the reliability of our unit tests.

Resources
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
proposal question unit-tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brandonmanke