Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider automating tests on circleci #68

Closed
lread opened this issue Oct 1, 2019 · 3 comments
Closed

consider automating tests on circleci #68

lread opened this issue Oct 1, 2019 · 3 comments

Comments

@lread
Copy link
Contributor

lread commented Oct 1, 2019

Hello!

Before working on #66, I found #67 and this made me wonder if you'd be interested in automating the running of tests on circleci.

As part of this work I propose:

  1. integrating cljs tests into lein via lein-cljsbuild.
  2. creating a circleci config that would automatically run tests on commit.

I don't know that automatically running the benchmark would be of interest/value, I guess it would test that it still works.

@lread
Copy link
Contributor Author

lread commented Oct 1, 2019

Also to consider for a test runner is kaocha. Note though that it has a minimum requirement of clojure 1.9 and I guess that would be a showstopper for you if you want to still want to support clojure 1.8.

@brandonbloom
Copy link
Owner

I'm not interested in adding any more tooling for a project this small and infrequently updated. Thanks though.

@lread
Copy link
Contributor Author

lread commented Oct 3, 2019

Fair enough! I totally understand one person's gift can be another person's burden and respect your choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants