From 63c34f4b0493a5bcd78523804e9764b0977ebb1d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?V=C3=ADctor=20Mart=C3=ADnez?= Date: Mon, 25 Nov 2024 10:41:47 +0100 Subject: [PATCH] [IMP] account_statement_base: Remove unnecessary code Unnecessary code when merging https://github.com/odoo/odoo/pull/182497 --- .../models/account_bank_statement.py | 19 ------------------- .../models/account_bank_statement_line.py | 7 ------- 2 files changed, 26 deletions(-) diff --git a/account_statement_base/models/account_bank_statement.py b/account_statement_base/models/account_bank_statement.py index f41e90f167..1b292f8b53 100644 --- a/account_statement_base/models/account_bank_statement.py +++ b/account_statement_base/models/account_bank_statement.py @@ -4,25 +4,6 @@ class AccountBankStatement(models.Model): _inherit = "account.bank.statement" - # TODO: Delete if merged https://github.com/odoo/odoo/pull/182497 - def _compute_date_index(self): - """The super() method does not take into account lines that do not have - internal_index set yet, and causes sorted() to fail, we need to re-define - the method in these cases to avoid the error. - """ - _self = self - for stmt in self: - if any(not line.internal_index for line in stmt.line_ids): - _self -= stmt - sorted_lines = stmt.line_ids.filtered("internal_index").sorted( - "internal_index" - ) - stmt.first_line_index = sorted_lines[:1].internal_index - stmt.date = sorted_lines.filtered(lambda line: line.state == "posted")[ - -1: - ].date - return super(AccountBankStatement, _self)._compute_date_index() - def action_open_statement_lines(self): self.ensure_one() if not self: diff --git a/account_statement_base/models/account_bank_statement_line.py b/account_statement_base/models/account_bank_statement_line.py index 4199a73fd2..857619b91b 100644 --- a/account_statement_base/models/account_bank_statement_line.py +++ b/account_statement_base/models/account_bank_statement_line.py @@ -7,13 +7,6 @@ class AccountBankStatementLine(models.Model): _inherit = "account.bank.statement.line" - # TODO: Delete if merged https://github.com/odoo/odoo/pull/182497 - def _compute_running_balance(self): - # We need to set value to all records because super() does not do it using sql. - for item in self: - item.running_balance = item.running_balance - return super()._compute_running_balance() - def action_open_journal_entry(self): self.ensure_one() if not self: