Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT] remove useless line in curvature_fit.py #82

Open
maximedieudonne opened this issue Dec 6, 2021 · 2 comments
Open

[MAINT] remove useless line in curvature_fit.py #82

maximedieudonne opened this issue Dec 6, 2021 · 2 comments

Comments

@maximedieudonne
Copy link
Contributor

maximedieudonne commented Dec 6, 2021

hello,
In the curvature_fit.py function i notice one useless line :

line 35 if (i == 175):
print("Debug")
Moreover there are commented lines :
line23-24 . vertex_normals =
faces=
line 44 rotation_matrix =
line 53. neigh =
line 68 parameters =

It's a little confused to have commented lines that defines variable differently,
can we remove this lines ?

thanks for your help

@maximedieudonne
Copy link
Contributor Author

Hi again,
I propose myself to clean this function

@alexpron
Copy link
Collaborator

alexpron commented Dec 7, 2021

Nice thank you very beaucoup @MaximeDdnn I can help linting if you open a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants