Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider dropping import path support #24

Open
bradleyfalzon opened this issue Sep 1, 2016 · 4 comments
Open

Consider dropping import path support #24

bradleyfalzon opened this issue Sep 1, 2016 · 4 comments
Milestone

Comments

@bradleyfalzon
Copy link
Owner

It's not possible to determine ahead of time which VCS path for a given import path without adding more code.

It maybe simpler to not support checking import paths, and instead, only check the local directory and it's sub directories.

@bradleyfalzon bradleyfalzon added this to the v1.0.0 milestone Sep 1, 2016
@dmitshur
Copy link

Are you familiar with vcs.RepoRootForImportPath?

@bradleyfalzon
Copy link
Owner Author

I had trolled those repos looking for libraries to use/read, I can't recall why I didn't use them, will reinvestigate. But thanks for the reminder, I think it maybe useful in another related project.

@ghost
Copy link

ghost commented Oct 7, 2016

No we're good on this one, give me a couple hours

@bradleyfalzon
Copy link
Owner Author

TODO needs additional tests (see some discussion in #31, but mostly lack of coverage in new commits.

@bradleyfalzon bradleyfalzon reopened this Oct 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants