-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor ListGroup
open close handling
#369
Conversation
Use helpers to reduce duplication.
This simplifies the existing open handling: * There is no need to compute `newlyAddedItemIds` (and cache it), instead we can just compute it from available data and use it immediately. * Removes most of the magic in this file (tm) (r) Related to camunda/camunda-modeler#4382
ListGroup
open close handling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this with bpmn-js-element-templates, and could not break it. Great improvement.
There's one thing which I don't get. After I link it, the placeholder tests in the bpmn-js-element-templates start to fail:
It looks unrelated though. |
This was due to an outdated |
Proposed Changes
This PR puts list group, on stable foundations, without magic ™️ ®️
Checklist
To ensure you provided everything we need to look at your PR:
@bpmn-io/sr
toolCloses {LINK_TO_ISSUE}
orRelated to {LINK_TO_ISSUE}
Related to camunda/camunda-modeler#4382