Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve palette visuals #848

Closed
Skaiir opened this issue Oct 17, 2023 · 0 comments · Fixed by #850
Closed

Improve palette visuals #848

Skaiir opened this issue Oct 17, 2023 · 0 comments · Fixed by #850
Assignees
@Skaiir
Labels
bug Something isn't working spring cleaning Could be cleaned up one day

Comments

@Skaiir
Copy link
Contributor

Skaiir commented Oct 17, 2023 •
edited
Loading

Describe the Bug

Not so much of a bug, but the palette has a bit of a strange visual design, as its contrast reduces on hover, which is a bit counter intuitive in terms of visuals.

Steps to Reproduce

  1. Hover over palette entry
  2. Palette entry grays out, which isn't ideal

grafik

Expected Behavior

We should if anything increase the contrast here. An outline might be the solution.

grafik
@Skaiir Skaiir added bug Something isn't working spring cleaning Could be cleaned up one day labels Oct 17, 2023
@Skaiir Skaiir self-assigned this Oct 17, 2023
Skaiir added a commit that referenced this issue Oct 17, 2023
@Skaiir
chore: restyled palette elements
9aae52b 
Closes #848
Related to #539
@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Oct 17, 2023
Skaiir added a commit that referenced this issue Oct 17, 2023
@Skaiir
chore: changed palette focus margin to outline
75f1d97 
Related to #848
Skaiir added a commit that referenced this issue Oct 17, 2023
@Skaiir
chore: reduced palette size following icon resize
082fd87 
Related to #848
@Skaiir Skaiir mentioned this issue Oct 17, 2023
Merged
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Oct 17, 2023
Skaiir added a commit that referenced this issue Oct 19, 2023
@Skaiir
chore: restyled palette elements
75e5b69 
Closes #848
Related to #539
Skaiir added a commit that referenced this issue Oct 19, 2023
@Skaiir
chore: changed palette focus margin to outline
e7c8632 
Related to #848
Skaiir added a commit that referenced this issue Oct 19, 2023
@Skaiir
chore: reduced palette size following icon resize
45363a9 
Related to #848
Skaiir added a commit that referenced this issue Oct 19, 2023
@Skaiir
chore: restyled palette elements
68228ea 
Closes #848
Related to #539
Skaiir added a commit that referenced this issue Oct 19, 2023
@Skaiir
chore: changed palette focus margin to outline
a1e5bea 
Related to #848
Skaiir added a commit that referenced this issue Oct 19, 2023
@Skaiir
chore: reduced palette size following icon resize
03fe542 
Related to #848
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Skaiir Skaiir

Labels
bug Something isn't working spring cleaning Could be cleaned up one day
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: palette style improvements bpmn-io/form-js
1 participant
@Skaiir